[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for `goto-

From: Phil Sainty
Subject: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for `goto-address-url-regexp'
Date: Mon, 25 Apr 2016 01:48:10 +1200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 24/04/16 23:36, Lars Magne Ingebrigtsen wrote:
> Having variable defaults depend on each other can be awkward, especially
> when it's the "first" variable that users will realistically be
> tweaking.

Yes indeed. I don't especially like the way I've done it -- but it
seemed like an improvement, nevertheless.

>> +(defvar goto-address-uri-schemes
> I don't much value to this "intermediate" variable.  It just makes
> things even more complicated to work with, I think.

It's true that this one is an intermediate by default; but it's one
which users might potentially want to set in order to say "I don't
care about the default schemes at all; I only want the specific
schemes I've specified here to be matched."

So of the two new variables I'm adding, a user might set one or the
other depending on their needs. That was my line of thought, anyhow.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]