[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20637: incompatible, undocumented change to vc-working-revision
From: |
Michael Albinus |
Subject: |
bug#20637: incompatible, undocumented change to vc-working-revision |
Date: |
Fri, 15 Apr 2016 15:11:14 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> Thanks. Any objections to committing this follow-up patch?
>
> It makes the tests look a lot more meaningful, and it passes for all
> backends, AFAICT, but I don't have e.g. Monotone installed.
I would prefer to apply further patches to the master branch only. Only
patches absolutely necessary for fixing problems shall go to the
emacs-25 branch, in order not to threaten the release.
After applying your patch, vc-tests.el fails for me in vc-test-src02-state
and vc-test-rcs03-working-revision.
> @@ -205,12 +205,10 @@ vc-test--create-repo
> (defun vc-test--unregister-function (backend file)
> "Run the `vc-unregister' backend function.
> For backends which dont support it, `vc-not-supported' is signalled."
> -
> - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend)))))
> - (if (functionp symbol)
> - (funcall symbol file)
> - ;; CVS, SVN, SCCS, SRC and Mtn are not supported.
> - (signal 'vc-not-supported (list 'unregister backend)))))
> + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal
> + ;; `vc-not-supported'.
> + (vc-call-backend backend 'unregister file)
> + (vc-file-clearprops file))
As said, in the master branch I would prefer to add a vc-unregister
function. Then we won't need this anymore.
Best regards, Michael.
bug#20637: incompatible, undocumented change to vc-working-revision, Michael Albinus, 2016/04/13
- bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/13
- bug#20637: incompatible, undocumented change to vc-working-revision, Michael Albinus, 2016/04/14
- bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/14
- bug#20637: incompatible, undocumented change to vc-working-revision, Michael Albinus, 2016/04/14
- bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/14
- bug#20637: incompatible, undocumented change to vc-working-revision,
Michael Albinus <=
- bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/16
- bug#20637: incompatible, undocumented change to vc-working-revision, Michael Albinus, 2016/04/18
- bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/18
- bug#20637: incompatible, undocumented change to vc-working-revision, Michael Albinus, 2016/04/18
bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/17
bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/14
bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/14
bug#20637: incompatible, undocumented change to vc-working-revision, Michael Albinus, 2016/04/15
bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/16
bug#20637: incompatible, undocumented change to vc-working-revision, Dmitry Gutov, 2016/04/17