bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20663: page.el (forward-page): Avoid skipping pages


From: Eli Zaretskii
Subject: bug#20663: page.el (forward-page): Avoid skipping pages
Date: Sat, 09 Apr 2016 15:00:06 +0300

> From: Marcin Borkowski <address@hidden>
> Date: Sat, 09 Apr 2016 12:13:11 +0200
> Cc: address@hidden
> 
> On 2015-05-26, at 19:14, Pierre Neidhardt <address@hidden> wrote:
> 
> > When `page-delimiter` starts at the beginning of the line and the position 
> > is
> > also at the beginning of the line, calling `forward-page` will skip one 
> > page.
> >
> > Running `emacs -Q example.txt`:
> >
> >     M-<
> >     C-x n p
> >     M->
> >     M-1 C-x n p
> >
> > This should bring us from page 1 to page 2, but page 3 gets displayed 
> > instead.
> >
> > The attached patch fixes it by changing the code to actually match its
> > surrounding comments.
> 
> Hi Emacs devs,
> 
> could someone take a look at the proposed patch?  It is not installed as
> of GNU Emacs 25.1.50.8 (commit 1e8cd05), and I don't feel competent
> enough to be sure it does not have any adverse side effects.

Maybe I'm missing something, but I don't see the connection between
the description of the bug, the recipe, and the patch.

The description talks about calling forward-page, but the recipe
doesn't call it.  The patch compares page-delimiter with an empty
string, but the default value of page-delimiter is not empty.

So I'm mightily confused by this.  Hopefully, someone will show me
what I'm missing.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]