bug#23053: 25.0.92; error in cc-mode when editing C# file with a generic class inheritance

[Jostein Kjønigsen]

On Fri, Mar 25, 2016, at 07:54 PM, Alan Mackenzie wrote:
> Thanks.  That was useful, and enabled me to reproduce the problem.  It's
> a separate bug from the one Saulius reported with csharp-mode, and occurs
> only in the Emacs master branch.  To be precise, a new variable
> introduced in that branch hadn't been given a proper initial value for
> Java (or, indeed, C#), so had the default value nil, which led to the
> error happening.
> 
> This bug has now been fixed and committed to the master branch of the
> Emacs git repository.  Would you please get the latest version, and
> confirm that the bug has been satisfactorally fixed.  Thanks!
>

I've tested for both java-mode and csharp-mode.

Once recompiled/reinstalled from melpa/marmalade csharp-mode loads fine
now. Thanks for the fix!

>> I'm still getting "wrong argument: stringp, nil" everywhere when
>> pressing enter interactively inside Emacs csharp-mode buffers.
> 
> I hope that's now fixed.

Indeed it is.

> Yes, that is indeed the case.  Two variables in master weren't
> properly initialised for Java, Pike, ...., and derived modes.  Sorry
> about that!

Shit happens. That's what bug-reports are for :)

>> Trying to run a "make test" of csharp-mode against git master, most of
>> the tests breaks:
> 
> Please let me know if this still happens.

Now 14 tests pass and only 1 test related to fontification breaks. The
fontification-tests have historically been somewhat unreliable, so I
wouldn't worry too much about that.

I'll consider this issue fixed at this point, and look into this single
test later.

>> Byte-compiling csharp-mode triggers a warning which so far haven't been
>> an issue for csharp-mode:
> 
> Yes.  Somebody in the Emacs team has decided that the second argument,
> previously optional, is now mandatory.  I wish people wouldn't do things
> like that.  The only thing sensible here is to add a second argument,
> nil, to each call to looking-back.

I've stalled doing this, due to not knowing if I will be changing the
semantics of the code. Do you know if inserting this nil-parameter is
what implicitly done by the compiler in cases such as these? Is such a
change guaranteed "safe"?

If you can confirm that, I can update the code to get rid of simple
issues like this.

> Can I ask you, as maintainer of csharp-mode:
> (i) To insert "(eval-when-compile (require 'cc-langs))" near the top of
>   csharp-mode.el.
> (ii) To add something to the manual telling users to compile
>   csharp-mode.el with the Emacs it's going to be run with.
> 
> (i) should help ensure csharp-mode gets properly compiled.  (ii) should
> also help ensure csharp-mode is properly compiled.  :-)
> 
> -- 
> Alan Mackenzie (Nuremberg, Germany).

Consider (i) done. As for (ii) that's usually not done by the user
itself, but by Emacs whenever there's an update to the package on MELPA
or marmalade.

I can add a note to the related bug on the csharp-mode issue-tracker
that this issue is resolved by reinstalling/recompiling the package
though.

Cheers!

-- 
Jostein Kjønigsen
jostein@kjonigsen.net / jostein@secure.kjonigsen.net