bug#22923: [PATCH] Support completion of attribute values in CSS mode

[Dmitry Gutov]

On 03/21/2016 11:14 AM, Simen Heggestøyl wrote:

> Yes, though on closer inspection, I see that it only happens in one case
> so far (the value class `bg-layer' referring to the property
> `background-color').

It seems like you could replace that reference with `color'.

> But more importantly, in the example above, the `image' value class
> refers to four other value classes, one of which has further references.
> This case is not handled by the current company-css, since it only
> recurses on values from the property alist.
>
> This is the main difference between `company-css-property-values' and
> `css--property-values': the former doesn't support referencing from the
> value class alist.
>
> (Indeed, there seems to be a bug in `company-css-value-classes' where
> `align-stretch' tries to refer to `align-common', but that won't work.)

You're right, it's a bug. I'd fix that with only making 
company-css-value-classes recursive (but not refer back to 
company-css-property-alist there).

To put it differently, I don't like that there's conflation of property 
values and property names: if there appears a value sometimes that is 
the same as some property's name (unlikely, I know), it would be hard to 
represent in the proposed structure.

Anyway, I've taken more than enough of your time. Please go ahead with 
whichever version you prefer.