bug#23006: 25.0.92; Loading Tramp breaks pcomplete in eshell-mode

[Stefan Monnier]

>>>> Can you explain *your* understanding of `non-essential', then?
>>>> What does this var mean, for you?
>>> For Tramp, it is an indication that file name completion is in
>>> progress.
>> Huh?  Why would it need such a variable for that, instead of getting
>> this info from the fact that you're replying to
>> `file-name-all-completions' (or `file-name-completion') rather than to
>> some other request?
> Because these aren't the only file name operations being called. You
> have seen it in the backtraces I've shown earlier.

But in that backtrace, it's OK for Tramp to open a new connection, since
the user hit TAB.

>> And why would it be called `non-essential' instead of `in-completion'?
> I wanted to introduce `completion-only'.

The crucial distinction to be made is not between "performing
completion" and "not performing completion", but between "any normal
operation, including completion in response to TAB" and "side-operations
like on-the-fly completion à la icomplete or company or background data
collection (like semantic might perform)".

> As I understand the codebase of Emacs 25, no other use of
> `non-essential' has appeared since then. Six years later.

It should be bound in desktop.el when reloading a desktop, but instead
desktop.el opted to use ad-hoc file-remote-p tests, IIUC.


        Stefan