[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11605: 24.1.50; vc-ediff revert annoyance

From: Lars Ingebrigtsen
Subject: bug#11605: 24.1.50; vc-ediff revert annoyance
Date: Fri, 26 Feb 2016 16:31:47 +1030
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Dmitry Gutov <address@hidden> writes:

> On 02/24/2016 08:33 AM, Lars Ingebrigtsen wrote:
>>> @@ -1815,11 +1815,13 @@ Use BACKEND as the VC backend if specified."
>>>             (delete-file filename))))
>>>       (vc-mode-line file))
>>>     (message "Checking out %s...done" filename)))
>>> -    (let ((result-buf (find-file-noselect filename)))
>>> +    (let ((result-buf (or (get-file-buffer filename)
>>> +                          (find-file-noselect filename))))
> Doesn't find-file-noselect call get-file-buffer anyway?

It does, but then it goes into all the "File %s changed on disk.  Reread
from disk?" stuff, which is what the bug is about.  But, I mean, the
file may have changed, so...

>>>        (with-current-buffer result-buf
>>>     ;; Set the parent buffer so that things like
>>>     ;; C-x v g, C-x v l, ... etc work.
>>> -   (set (make-local-variable 'vc-parent-buffer) filebuf))
>>> +   (set (make-local-variable 'vc-parent-buffer) filebuf)
>>> +        (revert-buffer nil t))
> It seems like this might conflict with other uses of vc-find-revision,
> like vc-revision-other-window. Where the user is allowed to change the
> contents of the returned buffer, and might've done so before we do
> this automatic silent revert.
> Maybe do it on ediff's side instead?

If the buffer with the comparison file had been killed before all this
had happened, we wouldn't have gotten the "file changed on disk" thing,
yes...  That may be a better fix.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]