[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20541: ERC password fetching using Secret Service API is broken
From: |
Michael Albinus |
Subject: |
bug#20541: ERC password fetching using Secret Service API is broken |
Date: |
Mon, 01 Jun 2015 11:20:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com> writes:
> One possible patch is attached below. This is the simplest solution; I
> have not thought much about whether it may be more desirable to convert
> numbers to strings inside the secrets.el package.
Well, secrets.el expects only strings as attributes. No conversion
foreseen. I don't know what auth-source.el does. If auth-source-search
also allows only strings (and symbol names) as attributes, then your
patch is right. Otherwise, if a :port attribute could also be an
integer, it shall be transformed to a string.
Ted?
> From 25f798b3b86a34bd6b262c59c3733d72eec50c13 Mon Sep 17 00:00:00 2001
> From: Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com>
> Date: Thu, 7 May 2015 13:01:24 +0200
> Subject: [PATCH] * lisp/erc/erc.el (erc-open): Fix password fetching
>
> ERC used to pass the port number as a number, however when using
> Secret Service API, only strings can be used.
>
> Copyright-paperwork-exempt: yes
> ---
> lisp/erc/erc.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index cf422f1..a8f1478 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel."
> (auth-source-search :host server
> :max 1
> :user nick
> - :port port
> + ;; secrets.el wouldn’t accept
> a number
> + :port (if (numberp port)
> (number-to-string port) port)
> :require '(:secret)))
> :secret)))
> (if (functionp secret)
> --
> 2.4.0
Best regards, Michael.
- bug#20541: ERC password fetching using Secret Service API is broken,
Michael Albinus <=