[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19102: 24.4; outline-move-subtree-up/down error at last and second-l
From: |
Stefan Monnier |
Subject: |
bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree |
Date: |
Tue, 25 Nov 2014 21:43:02 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> + (maybe-forward-char (lambda ()
> + (and (eobp) (not (bolp)) (newline))
> + (and (eolp) (not (bolp)) (forward-char 1))))
If we add a newline, we know don't want to do a `forward-char'. So:
(if (and (eobp) (not (bolp))) (newline)
(and (eolp) (not (bolp)) (forward-char 1)))))
Also, I don't understand the (not (bolp)) test in the second line: the
code it replaces only tested (= (char-after) ?\n). So I think it'd be
better to use:
(if (and (eobp) (not (bolp))) (newline)
(if (eq (char-after) ?\n) (forward-char 1)))))
And to be closer to the original code, I'd swap the two tests. And I'd
use `insert' rather than `newline' since I don't want to run abbrev
expansions and things like that.
(if (eq (char-after) ?\n) (forward-char 1)
(if (and (eobp) (not (bolp))) (insert "\n")))))
> + (empty-last-line (save-excursion
> + (goto-char (point-max))
> + (and (bolp) (eolp))))
At point-max, we know that (eolp) is non-nil, so you can just write
(empty-last-line (save-excursion
(goto-char (point-max))
(bolp))))
> - (error "Cannot move past superior level")))
> + (with-demoted-errors "%s"
> + (message "Cannot move past superior level"))))
This is wrong. Did you mean maybe to replace `error' with
`user-error' instead, maybe?
> + ;; If we added a newline to move forward, delete it.
> + (save-excursion
> + (goto-char (point-max))
> + (when (and (bolp) (eolp) (not empty-last-line))
> + (delete-char -1)))))
Let's not bother. There's no harm in adding a missing final newline
when we modify such a line-oriented file.
Stefan
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, (continued)
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Eli Zaretskii, 2014/11/22
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/22
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stefan Monnier, 2014/11/23
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/25
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Paul Rankin, 2014/11/25
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Paul Rankin, 2014/11/20
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/20
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Paul Rankin, 2014/11/20
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/21
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree,
Stefan Monnier <=
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stefan Monnier, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stefan Monnier, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stefan Monnier, 2014/11/26
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stephen Berman, 2014/11/27
- bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree, Stefan Monnier, 2014/11/27