[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19129: 25.0.50; recenter-positions is missing a reference to move-to
From: |
H. Dieter Wilhelm |
Subject: |
bug#19129: 25.0.50; recenter-positions is missing a reference to move-to-window-line-top-bottom |
Date: |
Fri, 21 Nov 2014 09:52:13 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm)
>> Date: Thu, 20 Nov 2014 23:14:38 +0100
>>
>> in the documentation for recenter-positions was forgotten that it is
>> also used in move-to-window-line-top-bottom. I added below patch as an
>> illustration.
>
> Nitpicking: In the future, please try to avoid unnecessarily changing
> parts that are unrelated to the proposed patch. This is especially
> true for human-readable text (as opposed to code), because it makes it
> very hard to determine where are you actually changing something.
I understand, I'll try to avoid it.
> In the case in point, I'm guessing you've filled the paragraphs of the
> doc string, which wasn't really necessary, since the lines were of
> reasonable length.
Yes, that's right, but I did it mistakenly because I thought it was
forgotten and that filling a paragraph would be necessary to be in
accordance to Elisp coding conventions.
Now I learned that even though emacs-lisp-docstring-fill-column is 65 an
80 column filling might be acceptable!
Thanks for the pointer.
Dieter
--
Best wishes
H. Dieter Wilhelm
Darmstadt, Germany
bug#19129: 25.0.50; recenter-positions is missing a reference to move-to-window-line-top-bottom, Eli Zaretskii, 2014/11/21