[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18332: 24.3.93; Convenience is a malformed function when installing

From: Stefan Monnier
Subject: bug#18332: 24.3.93; Convenience is a malformed function when installing ELPA package
Date: Tue, 02 Sep 2014 15:53:20 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

> rm -rf /tmp/foo
> mkdir -p /tmp/foo

> HOME=/tmp/foo emacs-24.3.93 -l package \
>   --eval "(progn (package-initialize) (package-refresh-contents) 
> (package-install 'yasnippet))"

> However I just get a byte-compilation warning, no error.

Don't know about the error, indeed.  I've fixed the two problems I saw
in the above test (first problem: the yasnippet-pkg.el file was
re-generated rather than just using the one that's in the tarball;
second problem: the file we generated did not properly quote the
arguments, hence the compilation warning).


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog      2014-09-02 18:16:32 +0000
+++ lisp/ChangeLog      2014-09-02 19:49:58 +0000
@@ -1,5 +1,13 @@
 2014-09-02  Stefan Monnier  <address@hidden>
+       * emacs-lisp/package.el (package-generate-description-file):
+       Properly quote the arguments (bug#18332).  Change second arg.
+       (package--alist-to-plist-args): Rename from package--alist-to-plist and
+       quote the elements.
+       (package--make-autoloads-and-stuff): Fix the test for pre-existence of
+       the *-pkg.el file.  Adjust to new calling convention of
+       package-generate-description-file.
        * progmodes/gud.el (gud-gdb-completion-at-point): Add hack (bug#18282).
        (gud-gdb-completions): Remove obsolete workaround.

=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el  2014-06-26 13:47:37 +0000
+++ lisp/emacs-lisp/package.el  2014-09-02 19:46:57 +0000
@@ -688,11 +688,9 @@
            (error "Package does not untar cleanly into directory %s/" dir)))))
-(defun package-generate-description-file (pkg-desc pkg-dir)
+(defun package-generate-description-file (pkg-desc pkg-file)
   "Create the foo-pkg.el file for single-file packages."
-  (let* ((name (package-desc-name pkg-desc))
-         (pkg-file (expand-file-name (package--description-file pkg-dir)
-                                     pkg-dir)))
+  (let* ((name (package-desc-name pkg-desc)))
     (let ((print-level nil)
           (print-quoted t)
           (print-length nil))
@@ -712,13 +710,20 @@
                            (list (car elt)
                                  (package-version-join (cadr elt))))
-          (package--alist-to-plist
+          (package--alist-to-plist-args
            (package-desc-extras pkg-desc))))
        nil pkg-file nil 'silent))))
-(defun package--alist-to-plist (alist)
-  (apply #'nconc (mapcar (lambda (pair) (list (car pair) (cdr pair))) alist)))
+(defun package--alist-to-plist-args (alist)
+  (mapcar (lambda (x)
+            (if (and (not (consp x))
+                     (or (keywordp x)
+                         (not (symbolp x))
+                         (memq x '(nil t))))
+                x `',x))
+          (apply #'nconc
+                 (mapcar (lambda (pair) (list (car pair) (cdr pair))) alist))))
 (defun package-unpack (pkg-desc)
   "Install the contents of the current buffer as a package."
@@ -751,9 +756,10 @@
 (defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
   "Generate autoloads, description file, etc.. for PKG-DESC installed at 
   (package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
-  (let ((desc-file (package--description-file pkg-dir)))
+  (let ((desc-file (expand-file-name (package--description-file pkg-dir)
+                                     pkg-dir)))
     (unless (file-exists-p desc-file)
-      (package-generate-description-file pkg-desc pkg-dir)))
+      (package-generate-description-file pkg-desc desc-file)))
   ;; FIXME: Create foo.info and dir file from foo.texi?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]