[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18347: 24.3.93; Incomplete splash screen display on Cygwin-w32 build
From: |
Eli Zaretskii |
Subject: |
bug#18347: 24.3.93; Incomplete splash screen display on Cygwin-w32 build |
Date: |
Fri, 29 Aug 2014 09:25:01 +0300 |
> Date: Thu, 28 Aug 2014 17:51:06 -0400
> From: Ken Brown <kbrown@cornell.edu>
>
> --- lisp/startup.el 2014-07-08 09:17:09 +0000
> +++ lisp/startup.el 2014-08-28 20:07:20 +0000
> @@ -1812,7 +1812,7 @@
> (let (chosen-frame)
> ;; MS-Windows needs this to have a chance to make the initial
> ;; frame visible.
> - (if (eq system-type 'windows-nt)
> + (if (eq window-system 'w32)
> (sit-for 0 t))
> (dolist (frame (append (frame-list) (list (selected-frame))))
> (if (and (frame-visible-p frame)
It is fundamentally wrong to use window-system the variable in such
circumstances (or almost any other). Please use the function instead.
> Is this still OK for the native Windows build? If so, is it OK to
> install it in the release branch?
Yes and yes. Although I'd urge you to try to figure out why this is
needed in the cygwin-w32 build (the native-build problem which led to
this code manifested itself in a rather different way, see bug#16014).