bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17699: [PATCH 7/7] * tests/automated/tildify-tests.el (tildify-test-


From: Michal Nazarewicz
Subject: bug#17699: [PATCH 7/7] * tests/automated/tildify-tests.el (tildify-test--test): Optimise the test slightly by reusing the same temporary buffer across multiple test cases.
Date: Thu, 5 Jun 2014 13:27:36 +0200

---
 test/ChangeLog                  |  4 ++++
 test/automated/tildify-tests.el | 10 +++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/test/ChangeLog b/test/ChangeLog
index 6248d6c..bb8ed89 100644
--- a/test/ChangeLog
+++ b/test/ChangeLog
@@ -1,5 +1,9 @@
 2014-06-05  Michal Nazarewicz  <mina86@mina86.com>
 
+       * automated/tildify-tests.el (tildify-test--test): Optimise the test
+       slightly by reusing the same temporary buffer across multiple test
+       cases.
+
        * automated/tildify-tests.el (tildify-test-find-env-end-re-bug)
        (tildify-test-find-env-group-index-bug): Update to support new
        signature of the `tildify-foreach-region-outside-env' function.
diff --git a/test/automated/tildify-tests.el b/test/automated/tildify-tests.el
index cf18320..86c83d7 100644
--- a/test/automated/tildify-tests.el
+++ b/test/automated/tildify-tests.el
@@ -54,16 +54,16 @@ If IS-XML is non-nil, <pre> tag is not treated specially."
   "Test tildify running in MODES.
 INPUT is the initial content of the buffer and EXPECTED is expected result
 after `tildify-buffer' is run."
-  (dolist (mode modes)
-    (with-temp-buffer
+  (with-temp-buffer
+    (dolist (mode modes)
+      (erase-buffer)
       (funcall mode)
       (let ((header (concat "Testing `tildify-buffer' in "
                             (symbol-name mode) "\n")))
         (insert header input)
         (tildify-buffer t)
-        (should (string-equal (concat header expected) (buffer-string)))))
-    (with-temp-buffer
-      (funcall mode)
+        (should (string-equal (concat header expected) (buffer-string))))
+      (erase-buffer)
       (let ((header (concat "Testing `tildify-region' in "
                             (symbol-name mode) "\n")))
         (insert header input)
-- 
2.0.0.526.g5318336






reply via email to

[Prev in Thread] Current Thread [Next in Thread]