bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17444: closed (Re: bug#17444: 24.3; cannot C-u M-x recompile (intera


From: B. L.
Subject: bug#17444: closed (Re: bug#17444: 24.3; cannot C-u M-x recompile (interactively) from outside *compilation* buffer.)
Date: Fri, 9 May 2014 09:55:08 -0500

Hi, thanks for the quick reply.  It could be that I am misunderstanding the use of recompile, but I have a quick follow-up question.  I have noticed that if I compile interactively (through C-u M-x compile), I receive an interactive *compilation* buffer that is in comint mode.  If I perform M-x recompile in the original source buffer, where I performed the compile, the code is recompiled but the *compilation* buffer is no longer in comint mode.  So in short the only way I can get comint mode to stay enabled during M-x recompile is to perform it in the *compilation* buffer only.  Is this correct functionality?

Many thanks!


On Fri, May 9, 2014 at 1:47 AM, GNU bug Tracking System <address@hidden> wrote:
Your bug report

#17444: 24.3; cannot C-u M-x recompile (interactively) from outside *compilation* buffer.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to address@hidden.

--
17444: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17444
GNU Bug Tracking System
Contact address@hidden with problems


---------- Forwarded message ----------
From: Glenn Morris <address@hidden>
To: address@hidden
Cc: 
Date: Fri, 09 May 2014 02:46:21 -0400
Subject: Re: bug#17444: 24.3; cannot C-u M-x recompile (interactively) from outside *compilation* buffer.
Version: 24.3.91

"B. L." wrote:

> Running C-u M-x recompile outside of the *compilation* buffer produces
> error:
> call-interactively: Wrong type argument: consp, nil

AFAICS, it doesn't make any sense to use `C-u M-x recompile' outside of a
compilation buffer, because it's the same as running `M-x compile'.
But I applied the following:

--- a/lisp/progmodes/compile.el 2014-02-10 01:34:22 +0000
+++ b/lisp/progmodes/compile.el 2014-05-09 06:42:39 +0000
@@ -1469,12 +1469,13 @@
   (interactive "P")
   (save-some-buffers (not compilation-ask-about-save)
                      compilation-save-buffers-predicate)
-  (let ((default-directory (or compilation-directory default-directory)))
+  (let ((default-directory (or compilation-directory default-directory))
+       (command (eval compile-command)))
     (when edit-command
-      (setcar compilation-arguments
-              (compilation-read-command (car compilation-arguments))))
-    (apply 'compilation-start (or compilation-arguments
-                                 `(,(eval compile-command))))))
+      (setq command (compilation-read-command (or (car compilation-arguments)
+                                                 command)))
+      (if compilation-arguments (setcar compilation-arguments command)))
+    (apply 'compilation-start (or compilation-arguments (list command)))))

 (defcustom compilation-scroll-output nil
   "Non-nil to scroll the *compilation* buffer window as output appears.



---------- Forwarded message ----------
From: "B. L." <address@hidden>
To: address@hidden
Cc: 
Date: Thu, 8 May 2014 23:39:09 -0500
Subject: 24.3; cannot C-u M-x recompile (interactively) from outside *compilation* buffer.
Running C-u M-x recompile outside of the *compilation* buffer produces error:
call-interactively: Wrong type argument: consp, nil

See thread on stackoverflow for more details if necessary.
http://stackoverflow.com/questions/23556169/c-u-m-x-recompile-error-wrong-type-argument-consp-nil/23556323#23556323

Is this a bug?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]