[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17379: 220.127.116.11 pretest: (ag-get-arg 0) somehow returns nil in the
bug#17379: 18.104.22.168 pretest: (ag-get-arg 0) somehow returns nil in the middle of advice
Wed, 30 Apr 2014 23:54:48 -0400
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)
tags 17379 wontfix
> Ok the repro steps are very specific. I've tried to make a simpler
> repro, but could not with the time I had.
> The important 2 line of code is here:
> The advice around it is very basic. The only interesting thing is
> after (setq test (ad-get-arg 0))
> test is nil, but original-items is correct.
The arglist of ido-set-matches-1 is (items &optional do-full), so
(ad-get-arg 0) is `items', which you have rebound to nil.
AFAICT, this bug is very old. And, AFAICT, you can't fix it without
breaking backward compatibility. The new advice mechanism in 24.4
(i.e. advice-add) does not suffer from these problems, tho.