[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16943: 24.3.50; [PATCH] `icomplete-exhibit' needs `with-current-buff
From: |
Drew Adams |
Subject: |
bug#16943: 24.3.50; [PATCH] `icomplete-exhibit' needs `with-current-buffer' for minibuffer |
Date: |
Wed, 5 Mar 2014 10:50:07 -0800 (PST) |
I have noticed, with both my version (icomplete+.el) and vanilla
icomplete.el, that in some cases no match of the user input is found
because the field string gets picked up from buffer *Completions*, not
from the minibuffer.
This might be because in my case I use a separate frame for the
minibuffer and for *Completions* (the latter has its input redirected to
the former).
The fix that seems most appropriate, I think, is this: wrap the body of
the `icomplete-exhibit' code with this:
(with-current-buffer (window-buffer (active-minibuffer-window))
E.g.:
(defun icomplete-exhibit ()
"Insert Icomplete completions display.
Should be run via minibuffer `post-command-hook'.
See `icomplete-mode' and `minibuffer-setup-hook'."
(when (and icomplete-mode
(icomplete-simple-completing-p)) ;Shouldn't be necessary.
(with-current-buffer (window-buffer (active-minibuffer-window))
(save-excursion
(goto-char (point-max))
...
In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
of 2014-03-04 on ODIEONE
Bzr revision: 116662 kbrown@cornell.edu-20140304190249-6s13s5bwn3un3hfe
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
'CFLAGS=-O0 -g3' 'CPPFLAGS=-DGC_MCHECK=1 -Ic:/Devel/emacs/include'
LDFLAGS=-Lc:/Devel/emacs/lib'
- bug#16943: 24.3.50; [PATCH] `icomplete-exhibit' needs `with-current-buffer' for minibuffer,
Drew Adams <=