[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16593: 24.3.50; ruby-mode: align chained method calls on multiple li

From: Dmitry Gutov
Subject: bug#16593: 24.3.50; ruby-mode: align chained method calls on multiple lines
Date: Fri, 31 Jan 2014 05:42:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 30.01.2014 16:35, Stefan Monnier wrote:
Warning (smie): Conflict: . </= .
Warning (smie): Conflict: . </= .

The smie-precs->prec2 part of your grammar says that "." = "." (because
of the new (assoc ".") you add there).

But the BNF part of your grammar says "." < "." (i.e. "foo . bar . baz"
is parsed as "foo . (bar . baz)" because of (id "." exp).

Fantastic, thanks for the explanation. With (assoc ".") changed to (right "."), the warning is gone.

I've also fixed the precedence of "." vs "? :" and modified a test case respectively. See the new patch attached.

Do you think it's not too late in the feature freeze to install a change like this, or should we wait until the trunk reopens?

We have a decent number of test cases, so it's not like the patch is likely to introduce major breakage.

Apparently there is no more conflict in the BNF in this respect so the
disambiguation constraint (assoc ".") that's passed to it is ignored.

Without that constraint there, SMIE showed warnings about ambiguities between ".", "," and "=". It somehow ignored the associativity, though.

The warnings with the previous patch also were gone when only the second one (assoc ".") were changed to (right "."). The first one, in the BNF disambiguation part, could be either.

Bozhidar, would you care to test the new patch?

Attachment: ruby-chained-calls.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]