bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16038: 24.3; latest change to with-help-window makes temp-buffer-bro


From: Leo Liu
Subject: bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless
Date: Wed, 22 Jan 2014 11:32:00 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.1)

On 2014-01-22 11:02 +0800, Stefan Monnier wrote:
[snipped 7 lines]
> Could you explain why it doesn't have any ill-effect?
> Put it another way, could you try to characterize in which case it would
> make a difference, and then try and figure out (or argue) that such
> a situation never happens or at least is very unlikely.
>
>
>         Stefan

On 2014-01-22 11:07 +0800, Glenn Morris wrote:
[snipped 3 lines]
> bzr log -c 1
>
>   -> timestamp: Thu 1985-04-18 00:48:29 +0000
>
>
> Anyway, vc-annotate is your friend:
>
> (add-hook 'temp-buffer-setup-hook 'help-mode-setup)
> appeared in r24049, 1999-01-11.
>
> (add-hook 'temp-buffer-show-hook 'help-mode-finish)
> appeared in r20061, 1997-10-15 (as help-mode-maybe).

Thanks.

------------------------------------------------------------
revno: 20061
committer: Karl Heuer <address@hidden>
timestamp: Wed 1997-10-15 23:36:30 +0000
message:
  (help-mode-maybe): New function, on temp-buffer-show-hook.
  (describe-key, describe-mode): Don't call help-mode here.
  (view-lossage, describe-function, describe-variable): Likewise.

------------------------------------------------------------
revno: 24049
committer: Richard M. Stallman <address@hidden>
timestamp: Mon 1999-01-11 15:25:41 +0000
message:
  (help-mode-finish): Renamed from help-mode-maybe.
  Don't switch to Help mode here.
  (temp-buffer-setup-hook): Use help-mode-finish.
  (help-mode-setup): New function.
  (temp-buffer-setup-hook): Use help-mode-setup.

So these hooks were added for help mode which is no longer using
with-output-to-temp-buffer but with-temp-buffer-window i.e. they are not
needed any more.

Stefan, do you have anything in mind that might be affected without
these add-hooks? Removing them would of course leave temp-buffers in
fundamental mode. But other than that I haven't seen anything strange.

Leo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]