[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16296: subword.el regexps shouldn't be constants

From: Phil Sainty
Subject: bug#16296: subword.el regexps shouldn't be constants
Date: Sun, 05 Jan 2014 00:32:25 +1300
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 4/01/2014 11:08, Stefan Monnier wrote:
> If there are reasons for users to change them, then feel free
> to revert them to defvars.

Great, thank you.

On 4/01/2014 07:16, Ted Zlatanov wrote:
> For reference, you mean this commit?
> revno: 113492
> fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758
> committer: Stefan Monnier <address@hidden>
> branch nick: trunk
> timestamp: Mon 2013-07-22 12:25:32 -0400
> message:
>   * lisp/progmodes/subword.el: Fix boundary case.
>   (subword-forward-regexp): Make it a constant.  Wrap optional \\W in its
>   own group.
>   (subword-backward-regexp): Make it a constant.
>   (subword-forward-internal): Don't treat a trailing capital as the
>   beginning of a word.
>   * test/automated/subword-tests.el: New file.

Yes, that's the one (although note that I'm not suggesting reverting
that entire commit; just the defvar -> defconst changes).

I've attached a patch.


Attachment: subword-regexp-vars.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]