bug#15661: 24.3.50; calendar.el broken

[Thierry Volpiatto]

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> Am 21.10.2013 09:47, schrieb Thierry Volpiatto:
>> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>>
>>> Am 20.10.2013 20:13, schrieb Glenn Morris:
>>>> Andreas Röhler wrote:
>>>>
>>>>> M-x diary-view-entries RET
>>>>>
>>>>> fails saying:
>>>>>
>>>>> Symbol's value as variable is void: displayed-month
>>>>
>>>> Works fine here. Recipe from emacs -Q?
>>>>
>>>
>>> Yes, started from emacs -Q
>>> Also got it from openSuse 12.3
>>
>> displayed-month among others is make local-var in calendar buffer,
>
> By the mode itself, which looks wrong,

Sure it is.

> as libraries outside like diary seem to make use of it also.
>
>  so if
>> you call the function from there (d), it will work as expected,
>> otherwise the var(s) is/are unknown(s).
>>
>
> Get this error also from
>
> M-x diary-view-other-diary-entries RET
>
> while
>
> M-x diary-show-all-entries RET
>
> works
>
> ;;;;;;;;
>
> Seeing inside calendar.el
>
> (unless (boundp 'displayed-month) (setq displayed-month 1))
>
> which doesn't look recommended.
>
> IIUC
>
> (defvar displayed-month 1)
>
> should DTRT.

The right thing should be to remove all these vars and reimplement the code
properly.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997