bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > 1. The Elisp manual says nothing about this.  Is this something new?
>
> No.
>
> > 2. What is wrong with code such as this at top level?
>
> Nothing.  But most of the cases I bumped into (all of which have been
> fixed now, AFAIK) were cases where the author had confused
> make-local-variable and make-variable-buffer-local.

Maybe

  "Warning: `make-variable-buffer-local' not called at toplevel"

would have the same learning experience, without saying "should be...",
which is wrong and confusing to people who know what they're doing.


Michael.