[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14670: Highlight visited links
From: |
Juri Linkov |
Subject: |
bug#14670: Highlight visited links |
Date: |
Fri, 28 Jun 2013 02:35:58 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) |
>> - (or (Info-next-reference-or-link pat 'link)
>> + (or (Info-next-reference-or-link pat 'shr-url)
>
> Why?
Actually there is no need to rename `link' to `shr-url' because
shr.el is flexible enough to allow arbitrary text properties for links:
(defun info-render-node (html)
(let ((shr-external-rendering-functions '((a . info-tag-a))))
(shr-insert-document html)))
(defun info-tag-a (cont)
(let ((url (cdr (assq :href cont)))
(start (point)))
(shr-generic cont)
(when url
(add-text-properties start (point)
(list 'link (shr-expand-url url))))))
So without renaming link text-props, the patch to support
text-prop links in Info becomes shorter:
=== modified file 'lisp/info.el'
--- lisp/info.el 2013-06-27 09:20:04 +0000
+++ lisp/info.el 2013-06-27 23:31:27 +0000
@@ -3863,6 +3919,8 @@ (defun Info-try-follow-nearest-node (&op
If FORK is non-nil, it is passed to `Info-goto-node'."
(let (node)
(cond
+ ((and (setq node (get-text-property (point) 'link)) (not (eq node t)))
+ (Info-goto-node node fork))
((setq node (Info-get-token (point) "[hf]t?tps?://"
"\\([hf]t?tps?://[^ \t\n\"`({<>})']+\\)"))
(browse-url node)
@@ -4701,6 +4766,18 @@ (defun Info-fontify-node ()
(add-text-properties (1- (match-beginning 2)) (match-end 2)
'(invisible t front-sticky nil rear-nonsticky
t)))))
+ ;; Fontify links
+ (goto-char (point-min))
+ (when not-fontified-p
+ (let ((beg (next-single-property-change (point-min) 'link))
+ (end nil))
+ (while (and beg (setq end (next-single-property-change beg 'link)))
+ (add-text-properties beg end
+ '(font-lock-face info-xref
+ mouse-face highlight
+ help-echo "mouse-2: go to this link"))
+ (setq beg (next-single-property-change end 'link)))))
+
;; Fontify cross references
(goto-char (point-min))
(when (or not-fontified-p fontify-visited-p)