[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14082: 24.3; Package dependences calculated in reverse
From: |
Stefan Monnier |
Subject: |
bug#14082: 24.3; Package dependences calculated in reverse |
Date: |
Wed, 03 Apr 2013 22:46:44 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> * rinari requires: ruby-mode, inf-ruby, ruby-compilation, jump
> * jump requires: findr, inflections
> * ruby-compilation requires: inf-ruby
> Yet, the order of compilation appears to be:
> 1. inflections
> 2. findr
> 3. jump
> 4. ruby-compilation *fails missing inf-ruby*
Indeed, thanks. I installed the patch below which should fix
this problem. Note that a better fix would be to first download packages,
the unpack packages, then autoload packages, then compile packages.
This way, ordering won't matter (including circular dependencies).
Stefan
=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el 2013-04-04 01:51:33 +0000
+++ lisp/emacs-lisp/package.el 2013-04-04 02:42:31 +0000
@@ -811,7 +811,10 @@
(package-version-join (package-desc-vers (cdr pkg-desc)))))
;; Only add to the transaction if we don't already have it.
(unless (memq next-pkg package-list)
- (push next-pkg package-list))
+ (setq package-list
+ ;; Move to front, so it gets installed early enough
+ ;; (bug#14082).
+ (cons next-pkg (delq next-pkg package-list))))
(setq package-list
(package-compute-transaction package-list
(package-desc-reqs
- bug#14082: 24.3; Package dependences calculated in reverse,
Stefan Monnier <=