bug#13972: 24.3.50; Cannot delete bookmark

[Thierry Volpiatto]

Xue Fuqiao <xfq.free@gmail.com> writes:

> I have three bookmarks:
>
>   TODO                                /usr/local/share/emacs/24.3.50/etc/TODO
>   startup.el                  ~/emacs-bzr/trunk/lisp/startup.el
>   text property                       /usr/local/share/info/elisp
>
> All of these files exist.  To reproduce this bug:
>
>   emacs -Q
>   C-x r l
>   d x
>
> The echo area says: "Deleting bookmarks...done".
>
> But the bookmark isn't deleted.  I have attached my
> ~/.emacs.d/bookmarks.

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 47e1379..ee6e050 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1582,8 +1582,8 @@ deletion, or > if it is flagged for displaying."
     (if bookmark-bmenu-use-header-line
        (bookmark-bmenu-set-header)
       (forward-line bookmark-bmenu-inline-header-height))
-    (if bookmark-bmenu-toggle-filenames
-        (bookmark-bmenu-toggle-filenames t))))
+    (when (and bookmark-alist bookmark-bmenu-toggle-filenames)
+      (bookmark-bmenu-toggle-filenames t))))
 
 ;;;###autoload
 (defalias 'list-bookmarks 'bookmark-bmenu-list)

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997