[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#1806: dired-pop-to-buffer in wrong place
From: |
Juri Linkov |
Subject: |
bug#1806: dired-pop-to-buffer in wrong place |
Date: |
Thu, 04 Oct 2012 02:29:57 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) |
>>> Anyone who wants the nil behavior for `dired-shrink-to-fit' can add a
>>> corresponding entry to `display-buffer-alist' as you proposed earlier.
>>
>> This means that `dired-shrink-to-fit' could be marked obsolete?
>
> I think so.
>
>>> (Someone would have to formulate that for users nicely and in the
>>> appropriate context.)
Do you think this is a good formulation:
=== modified file 'lisp/dired.el'
--- lisp/dired.el 2012-09-30 12:11:18 +0000
+++ lisp/dired.el 2012-10-03 23:28:07 +0000
@@ -248,6 +248,10 @@ (defvar dired-shrink-to-fit t
;; I see no reason ever to make this nil -- rms.
;; (> baud-rate search-slow-speed)
"Non-nil means Dired shrinks the display buffer to fit the marked files.")
+(make-obsolete-variable 'dired-shrink-to-fit
+ "use the Customization interface to add a new rule
+to `display-buffer-alist' where condition regexp is \"Marked Files\",
+action argument symbol is `window-height' and its value is nil." "24.3")
(defvar dired-file-version-alist)
@@ -2940,6 +2943,7 @@ (defun dired-mark-prompt (arg files)
(defun dired-pop-to-buffer (buf)
"Pop up buffer BUF in a way suitable for Dired."
+ (declare (obsolete dired-mark-pop-up "24.3"))
(let ((split-window-preferred-function
(lambda (window)
(or (and (let ((split-height-threshold 0))
@@ -2981,6 +2985,11 @@ (defun dired-mark-pop-up (buffer-or-name
window is not shown if there is just one file, `dired-no-confirm'
is t, or OP-SYMBOL is a member of the list in `dired-no-confirm'.
+By default Dired shrinks the display buffer to fit the marked files.
+To disable this, use the Customization interface to add a new rule
+to `display-buffer-alist' where condition regexp is \"Marked Files\",
+action argument symbol is `window-height' and its value is nil.
+
FILES is the list of marked files. It can also be (t FILENAME)
in the case of one marked file, to distinguish that from using
just the current file.
PS: Also I noticed that there are no new actions in the Customization
interface for `display-buffer-alist'. I guess you omitted the action
`display-buffer-at-bottom' because it's not yet ready for prime time.
But is there a reason to not add `display-buffer-below-selected' to
`display-buffer--action-function-custom-type'?
- bug#1806: dired-pop-to-buffer in wrong place,
Juri Linkov <=