bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el

[Stefan Merten]

Hi Masatake!

Yesterday Masatake YAMATO wrote:
>>> This is not a bug report. This is a request to merge a patch
>>> to the offcial source tree.

Thanks for the patch.

>>> 2012-06-13  Masatake YAMATO  <yamato@redhat.com>
>> 
>>>     * textmodes/rst.el (rst-mode, rst-imenu-index): Added
>>>     imenu and which-func support.
>> 
>> I'll let the other Stefan decide what to do with it.  It looks
>> pretty good for me.  Just a few nitpicks below:

It is definitely interesting. So far I never used imenu but it looks
like a very useful thing.

I already integrated your patch in my development version. However,
I'll massage it a bit to fit better.

> I found I should explain more about to the maintainer.

Good idea.

> I know `rst-toc'. People who writes a document in rst format may use
> `rst-toc' instead of imenu.

I'm thinking about whether opening a second method for this type of
functionality using imenu. Indeed imenu is a mature framework and it
is useful to use this instead of homebrew stuff like `rst-toc`.

For instance I also have using the speed bar with `rst-mode`. The
imenu documentation says it supports the speed bar somehow - so this
might be a quick win :-) .

> However, there is a reason I write this
> patch. Sometime I read document writtn in rst file by my colleagues(on
> emacs running on a terminal). In such case `which-func' helps me to
> understand the document; and `which-func' uses imenu internally.

I didn't get `which-func` to work - not even in Emacs Lisp mode. The
documentation says

  When Which Function mode is enabled, the current function name is
  continuously displayed in the mode line, in certain major modes.

Unfortunately the mode line doesn't change when I say
`which-func-mode` :-( .

[...checking...]

Ah that's probably because I

   (setq default-mode-line-format ...)

in my `.emacs`. Uuh, these stone-old customizations bite sometimes :-( .


                                                Grüße

                                                Stefan

pgp5qQtvq6hBA.pgp
Description: PGP signature