bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11508: 24.1.50; Off-by-one error in xg_select?


From: Andreas Schwab
Subject: bug#11508: 24.1.50; Off-by-one error in xg_select?
Date: Sat, 19 May 2012 11:52:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux)

Jan Djärv <jan.h.d@swipnet.se> writes:

> So the question is, is it more effective to give select the exact value
> (select works fine if nfds has a higher value than strictly neccessary),
> or always increment by one in lines 78 and 83?

IMHO it doesn't hurt to be exact, and the patch removes an inconsistency
which makes it easier to understand the code.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





reply via email to

[Prev in Thread] Current Thread [Next in Thread]