[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on
From: |
Drew Adams |
Subject: |
bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows |
Date: |
Mon, 7 May 2012 08:44:53 -0700 |
> > (Btw, what's the purpose of using eval-when-compile here?)
>
> To avoid calling `concat' at run-time (especially within the loop).
> In older Emacsen, `concat' was marked as pure so the
> byte-compiler would evaluate it at compile-time, but someone
> complained that it's not strictly correct because he wanted that
> (concat <foo>) is not `eq' to (concat <foo>). I actually think
> this change was a mistake and would rather mark `concat' as pure again.
That sounds like the kind of explanation that would help readers as a comment in
the code. If someone as attentive as Eli has to ask this then it might not hurt
to inform readers generally.
(Ignore my suggestion if inappropriate - I'm not following the thread etc.)
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, (continued)
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Stefan Monnier, 2012/05/04
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Eli Zaretskii, 2012/05/04
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Stefan Monnier, 2012/05/05
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Eli Zaretskii, 2012/05/05
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Chong Yidong, 2012/05/07
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Eli Zaretskii, 2012/05/07
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Stefan Monnier, 2012/05/07
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows,
Drew Adams <=
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Chong Yidong, 2012/05/07
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Stefan Monnier, 2012/05/07
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Eli Zaretskii, 2012/05/08
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Stefan Monnier, 2012/05/09
- bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows, Eli Zaretskii, 2012/05/09