bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#10421: Don't use the abbreviation "win" to refer to Windows.


From: Eli Zaretskii
Subject: bug#10421: Don't use the abbreviation "win" to refer to Windows.
Date: Mon, 02 Jan 2012 03:29:59 -0500

> Date: Sun, 01 Jan 2012 22:45:52 -0800
> From: Paul Eggert <address@hidden>
> 
> I found several instances in the Emacs source code of its
> unnecessarily using the abbreviation "win" to refer to Windows.
> Here's a proposed patch.

Thanks.

> --- src/ChangeLog.10  2011-12-12 05:32:49 +0000
> +++ src/ChangeLog.10  2012-01-02 06:41:42 +0000
> @@ -21476,7 +21476,7 @@
>       "Emacs built on Windows 9x/ME crashes at startup on Windows XP,
>       or Emacs builtpart of on XP crashes at startup on Windows 9x/ME."
>  
> -     * w32.c: Added wrapper functions around the win32 API functions
> +     * w32.c: Added wrapper functions around the w32 API functions
>       OpenProcessToken, GetTokenInformation, LookupAccountSid, and
>       GetSidIdentifierAuthority.  These wrapper functions serve two
>       purposes:
> @@ -21490,7 +21490,7 @@
>       the version of advapi32.dll that is found in the 9x branch of
>       Microsoft Windows.
>  
> -     * w32.c (init_user_info): Replace the calls to the win32 API
> +     * w32.c (init_user_info): Replace the calls to the w32 API
>       functions OpenProcessToken, GetTokenInformation, LookupAccountSid,
>       and GetSidIdentifierAuthority with calls to the newly added
>       wrapper functions.

These two are wrong: "Win32 API" is the proper name of the API.
There's no such thing as "w32 API".

> --- src/sound.c       2011-11-20 07:30:16 +0000
> +++ src/sound.c       2012-01-02 06:41:42 +0000
> @@ -30,7 +30,7 @@
>    cause an error to be generated.
>  
>    The Windows implementation of play-sound is implemented via the
> -  Win32 API functions mciSendString, waveOutGetVolume, and
> +  w32 API functions mciSendString, waveOutGetVolume, and
>    waveOutSetVolume which are exported by Winmm.dll.
>  */

Likewise.

> --- src/w32fns.c      2011-12-04 08:02:42 +0000
> +++ src/w32fns.c      2012-01-02 06:41:42 +0000
> @@ -6598,7 +6598,7 @@
>    value = Qnil;
>  
>    /* Determining the required information on Windows turns out, sadly,
> -     to be more involved than one would hope.  The original Win32 api
> +     to be more involved than one would hope.  The original w32 api
>       call for this will return bogus information on some systems, but we
>       must dynamically probe for the replacement api, since that was
>       added rather late on.  */

Likewise.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]