[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9960: "emacsclient.c (main) <environ>: Remove declaration, " breaks
From: |
David Caldwell |
Subject: |
bug#9960: "emacsclient.c (main) <environ>: Remove declaration, " breaks build on Mac OS X |
Date: |
Mon, 28 Nov 2011 01:34:48 -0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
FYI, I get this error when compiling Emacs for Mac OS X (x86_64, i386,
and PowerPC):
> gcc -mmacosx-version-min=10.5 -std=gnu99 -Wimplicit-function-declaration
> -Wold-style-definition -Wdeclaration-after-statement -DHAVE_CONFIG_H -I.
> -I../src -I../lib
> -I/Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src
> -I/Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/../src
> -I/Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/../lib -g
> -O2
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c \
> -DVERSION="\"24.0.91\"" \
> ../lib/libgnu.a -o emacsclient
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c:
> In function 'set_local_socket':
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c:1281:
> warning: passing argument 2 of 'confstr' discards qualifiers from pointer
> target type
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c:
> In function 'main':
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c:1639:
> error: 'environ' undeclared (first use in this function)
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c:1639:
> error: (Each undeclared identifier is reported only once
> /Users/david/src/emacs-dev/emacs-bzr/build-2011-11-28/lib-src/emacsclient.c:1639:
> error: for each function it appears in.)
It appears to be caused by this checkin:
> revno: 106533
> fixes bug(s): http://debbugs.gnu.org/9960
> committer: Eli Zaretskii <eliz@gnu.org>
> branch nick: trunk
> timestamp: Sun 2011-11-27 20:52:53 +0200
> message:
> Fix MS-Windows build with MSVC compiler.
I'm guessing it's this hunk:
=== modified file 'lib-src/emacsclient.c'
--- lib-src/emacsclient.c 2011-11-14 20:23:26 +0000
+++ lib-src/emacsclient.c 2011-11-27 18:52:53 +0000
@@ -1635,7 +1635,6 @@
/* Send over our environment and current directory. */
if (!current_frame)
{
- extern char **environ;
int i;
for (i = 0; environ[i]; i++)
{
Thanks,
David
signature.asc
Description: OpenPGP digital signature
bug#9960: Compiling Emacs trunk with MSVC, Fabrice Popineau, 2011/11/05
bug#9960: fix for Bug#9772 should also help fix Bug#9960, Paul Eggert, 2011/11/08
bug#9960: "emacsclient.c (main) <environ>: Remove declaration, " breaks build on Mac OS X,
David Caldwell <=
bug#9960: : "emacsclient.c (main) <environ>: Remove declaration, " breaks build on Mac OS X, Leon Zhang, 2011/11/28
bug#9960: Compiling Emacs trunk with MSVC, Tim Crews, 2011/11/30