[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#9597: 23.3; [diff-mode] Can't quite cope with git patches

From: Juri Linkov
Subject: bug#9597: 23.3; [diff-mode] Can't quite cope with git patches
Date: Tue, 27 Sep 2011 03:03:50 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu)

>> I suppose that modifying the buffer with inserting a newline
>> is a temporary workaround for some earlier bug, so I added
>> a check for the diff separator in another condition branch.
> No, it's not outdated.
> The issue is in diff-end-of-hunk where we can sometimes use the numbers
> but not always.
> Also, adding a newline makes the thing less ambiguous in cases such as
> when the user edits the hunks (in which case we need to update the hunk
> header based on the hunk text).

Maybe we should add an option that doesn't insert a newline
for users who don't want that viewing diff files modifies them.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]