[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9353: 24.0.50; default grep file name face is uglier now
From: |
Juri Linkov |
Subject: |
bug#9353: 24.0.50; default grep file name face is uglier now |
Date: |
Wed, 24 Aug 2011 00:32:39 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) |
> See attached images. The old face inherited from `font-lock-type-face',
> and the appearace was OK (though not wonderful).
> The new face inherits from a face called `success'. It is uhhhhgggly.
FYI, old is new and new is old. I copied the default value of `success'
from the old face definition of `compilation-info' that existed in Emacs 23
and older. OTOH, colors of `font-lock-type-face' for grep are new
(6 months in the repository).
> For one thing, it should not be bold. We should almost never use a bold
> face as the default face for something, because boldness does not work
> well on some platforms and for some (many) faces.
I agree, e.g. with my 10px fonts, bold is unreadable.
So I reset the bold attribute from all used faces.
Moreover, I customized this face to "ForestGreen",
i.e. to the color you are suggesting now.
So I agree it's better than the current face definition.
The only reason why I took the old value is because I thought
it's safer to use the old face no one complained about.
> I applaud not inheriting from a font-lock face: there is no logical
> connection to a grepped file. But there is also no logical connection
> to "success" here.
I think if we'll copy the face definition from `font-lock-type-face'
to `success', the former should not inherit from the latter,
because they are not logically related.
bug#9353: 24.0.50; default grep file name face is uglier now, Stefan Monnier, 2011/08/23