[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#8862: compilation-window-height no good anymore
From: |
Stefan Monnier |
Subject: |
bug#8862: compilation-window-height no good anymore |
Date: |
Wed, 15 Jun 2011 11:38:32 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> AFAIK, `enlarge-window' did not signal an error when the size was too
>> large, so I think it's best to keep being silent, for backward
>> compatibility's sake.
> OK. I'll use the maximum possible height for enlarging and
> window-min-height/-width for shrinking. The only cases where I signal
> an error are when the window is either fixed-size or the root window.
In Emacs-23, enlarge-window called on the root window doesn't seem to
signal an error either. Maybe you'll be lucky and won't bump into bugs
resulting from such a change, but I think you'd be safer keeping the old
non-signaling behavior.
After all, you don't like enlarge-window anyway and can't really change
it into something you like, so you may as well keep it unchanged and
deprecate it in favor of something you like better.
> Agreed. I tend to discourage using `enlarge-window' in ELisp because it
> only works on the selected window leading to things like compile.el's
> ;; Stef said that doing the saves in this order is safer:
> (save-excursion
> (save-selected-window
> (select-window window)
> (enlarge-window (- height (window-height))))))))
Hmm... not sure why it doesn't use with-selected-window, but yes,
providing a `window' argument is even better.
Stefan
- bug#8862: compilation-window-height no good anymore, jidanni, 2011/06/14
- bug#8862: compilation-window-height no good anymore, martin rudalics, 2011/06/14
- bug#8862: compilation-window-height no good anymore, Nix, 2011/06/14
- bug#8862: compilation-window-height no good anymore, martin rudalics, 2011/06/14
- bug#8862: compilation-window-height no good anymore, Nix, 2011/06/14
- bug#8862: compilation-window-height no good anymore, Stefan Monnier, 2011/06/14
- bug#8862: compilation-window-height no good anymore, martin rudalics, 2011/06/15
- bug#8862: compilation-window-height no good anymore, Stefan Monnier, 2011/06/15
- bug#8862: compilation-window-height no good anymore, martin rudalics, 2011/06/15
- bug#8862: compilation-window-height no good anymore,
Stefan Monnier <=
- bug#8862: compilation-window-height no good anymore, martin rudalics, 2011/06/15
bug#8862: compilation-window-height no good anymore, jidanni, 2011/06/14
bug#8862: compilation-window-height no good anymore, jidanni, 2011/06/15
bug#8862: compilation-window-height no good anymore, jidanni, 2011/06/15
bug#8862: compilation-window-height no good anymore, jidanni, 2011/06/15