[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#8329: 23.3.50; [PATCH] Get rid of one ido ugliness

From: Leo
Subject: bug#8329: 23.3.50; [PATCH] Get rid of one ido ugliness
Date: Thu, 24 Mar 2011 22:34:26 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7)

On 2011-03-24 04:27 +0800, Stefan Monnier wrote:
>> The following patch replaces ugly completing-read form with a simpler
>> and cleaner read-from-minibuffer.
> Kim, any opinion?

Please also review the diff hunk:

@@ -4590,17 +4581,13 @@ (defun ido-exhibit ()
        ;; Insert the match-status information:
-       (let ((inf (ido-completions
-                   contents
-                   minibuffer-completion-table
-                   minibuffer-completion-predicate
-                   (not minibuffer-completion-confirm))))
+       (let ((inf (ido-completions contents)))
          (setq ido-show-confirm-message nil)
          (ido-trace "inf" inf)
          (insert inf))
-(defun ido-completions (name candidates predicate require-match)
+(defun ido-completions (name)
   ;; Return the string that is displayed after the user's text.
   ;; Modified from `icomplete-completions'.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]