[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#8267: Acknowledgement (unexec FIXME in src/emacs.c)

From: Paul Eggert
Subject: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c)
Date: Thu, 17 Mar 2011 11:45:18 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9

On 03/17/2011 11:02 AM, Ken Brown wrote:
On 3/17/2011 12:54 PM, Paul Eggert wrote:
I've committed a patch for this in bzr103679.

In unexec.h you declare unexec() to return void, but in several of the 
unexec*.c files it has a return type of int.

Thanks for catching that.  I didn't notice that, since I built
on an implementation where it returns void.  I changed the
other implementations to match the new header (bzr 103680).

It might make sense for unexec to return an int, so that Emacs
can report an error (presumably from errno) if unexec fails,
but if this is done it should be done consistently on all
platforms.  The previous code was inconsistent.  The implementations
that returned an int sometimes returned 0 even when there were

reply via email to

[Prev in Thread] Current Thread [Next in Thread]