bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#8261: Perl mode imenu index ignores my/our variables


From: Ralph Schleicher
Subject: bug#8261: Perl mode imenu index ignores my/our variables
Date: Tue, 15 Mar 2011 21:34:27 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Hi,

in Perl mode the imenu index does not list variables declared via 'my'
and 'our'.  Below is a patch together with a change log entry to fix it.
Please note that the regular expression is "\\(?:my\\|our\\))\\s-+" and
not "\\(?:\\(?:my\\|our\\))\\s-+\\)?" (optional match).  Not declaring
global variables properly is generally considered bad Perl style.


2011-03-11  Ralph Schleicher  <address@hidden>

        * progmodes/perl-mode.el (perl-imenu-generic-expression): Only
        match variables declared via `my' or `our'.


--- emacs-23.3/lisp/progmodes/perl-mode.el.orig 2011-01-08 12:45:14 +0100
+++ emacs-23.3/lisp/progmodes/perl-mode.el      2011-03-11 11:39:42 +0100
@@ -167,7 +167,7 @@
   '(;; Functions
     (nil "^sub\\s-+\\([-A-Za-z0-9+_:]+\\)" 1)
     ;;Variables
-    ("Variables" "^\\(address@hidden:]+\\)\\s-*=" 1)
+    ("Variables" "^\\(?:my\\|our\\)\\s-+\\(address@hidden:]+\\)\\s-*=" 1)
     ("Packages" "^package\\s-+\\([-A-Za-z0-9+_:]+\\);" 1)
     ("Doc sections" "^=head[0-9][ \t]+\\(.*\\)" 1))
   "Imenu generic expression for Perl mode.  See `imenu-generic-expression'.")


-- 
Ralph





reply via email to

[Prev in Thread] Current Thread [Next in Thread]