bug#7236: 24.0.50; make-local-hook missing

[Stefan Monnier]

>> >>> Start emacs, ask for the documentation for make-local-hook. The
>> >>> program signals [No Match].
SM> It's been removed, indeed.  It was obsolete since Emacs-21.
>> > How could I  replace it ?
>> You don't need to: calls to make-local-hook have been unnecessary since
>> Emacs-21.
> Stop being so dismissive, for crying out loud!

I'm sorry if I sounded dismissive, but I assure you that it was not
my intention.

> Whilst what you've said is true, it evades the point.  That point is
> that there is lots of elisp code (including standalone CC Mode) which
> calls the damned function, and now that it has been removed, that code
> does not compile.  This is inconvenient.

Then maybe we shouldn't remove it yet.

> I think that m-l-h is only unnecessary when the LOCAL param is set in
> some calls to `add-hook'; i.e. for each instance of m-l-h, some hacker
> has carefully to work out what the implications are.

No: m-l-h is also unnecessary when add-hook is called with a nil LOCAL
argument.  I know of no case where calling make-local-hook makes
a difference in Emacs>=21.

> Removing `make-local-hook' is causing bother.  It's eradication may be
> worth that bother.  But please accept that that bother exists.

I never said otherwise.  This bug-report is the first complaint I hear
about it, so it's not obvious at all that this is a big issue.

I'll be happy to add a (define-obsolete-function-alias 'make-local-hook
'ignore "21.1") if removing that definition is somewhat problematic.
As you know, we're usually pretty conservative when it comes to removing
obsolete stuff.


        Stefan