[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#4451: 23.1; EOL problems with vc-diff and cygwin
From: |
Eli Zaretskii |
Subject: |
bug#4451: 23.1; EOL problems with vc-diff and cygwin |
Date: |
Thu, 15 Jul 2010 11:33:15 +0300 |
> From: Reiner Steib <reinersteib+gmane@imap.cc>
> Cc: 4451@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 15 Jul 2010 09:22:39 +0200
>
> > So I agree with Stefan that you should simply not overwrite the
> > checked-out file with Unix EOLs. We could install the change
> > suggested by Stefan (based on this analysis, I no longer object to
> > it),
>
> If nobody else objects, may I install[1] Stefan's patch? Or we could
> make it depend on some variable as well ...
Fine with me.
> +(defvar vc-coding-system-strip-eol t ;; nil
> + "When non-nil, don't inherit the EOL part of the coding-system.")
Instead of a slightly misleading name (you don't really "strip" EOL)
and double negation, I would suggest an option named
vc-coding-system-inherit-eol, non-nil by default (to keep the current
operation), and reverse the condition in the patch.