bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5934: 24.0.50; get rid of "unix" pre-defined macro when preprocessin


From: Chong Yidong
Subject: bug#5934: 24.0.50; get rid of "unix" pre-defined macro when preprocessing Makefile
Date: Mon, 12 Apr 2010 10:00:02 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.95 (gnu/linux)

Miles Bader <address@hidden> writes:

> Emacs uses the C preprocessor to process src/Makefile.in, and the CPP on
> many systems defines the token "unix" (to be "1") for historical
> reasons.
>
> This has bad results if some of the Makefile contents include that
> token; in particular, on my system, the definition of ALL_CFLAGS
> contains " -I/usr/include/gio-unix-2.0/", and due to the bogus
> predefined unix macro, this ends up as something that's not even legal
> compiler command-line syntax.
>
> Luckily,  the "unix" macro isn't actually used by Makefile
> preprocessing, so it's simple enough to add that to the list of things
> which the Emacs configure script explicitly undefines when doing
> Makefile preprocessing.
>
> The following patch does this:

Looks good, could you check it into the trunk?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]