[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5882: [Aquamacs-bugs] Re: yes-or-no-p menu

From: jhd
Subject: bug#5882: [Aquamacs-bugs] Re: yes-or-no-p menu
Date: Thu, 08 Apr 2010 17:01:50 -0000

Does this patch fix it?

*** xmenu.c     24 May 2005 19:13:15 -0400      1.290
--- xmenu.c     03 Jun 2005 18:32:12 -0400
*** 1235,1240 ****
--- 1235,1243 ----
        if (event.type == ButtonRelease
            && dpyinfo->display == event.xbutton.display)
+         if (x_any_window_to_frame (dpyinfo, event.xexpose.window))
+           popup_activated_flag = 0;
            dpyinfo->grabbed &= ~(1 << event.xbutton.button);
  #ifdef USE_MOTIF /* Pretending that the event came from a
                      Btn1Down seems the only way to convince Motif to

What this patch does is that it makes the dialog pop down for a click in an Emacs window for Lesstif/Motif and Lucid only. We discussed this before, this is not the way a dialog shall behave (as seen in other GUI programs), and the code was explicitly changed to not pop down dialogs on click outside the dialog around december 2004.

However, it *is* the way a menu shall behave. Menus are used instead of dialogs when compiling on X11 without a toolkit, and on Mac (and perhaps W32, I am not sure). So on those ports, the dialog (really menu) shall pop down on a click outside the menu. And for X11 it already does that, and now it does that for Mac also. I suggest reverting this patch.

    Jan D.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]