[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#516: [PATCH] Minor Enhancement for grep.el: auto-input thesymbol int
bug#516: [PATCH] Minor Enhancement for grep.el: auto-input thesymbol into minibuffer command line.
Sat, 05 Dec 2009 21:51:17 +0200
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)
>> > This patch is to let you input the cursor position symbol
>> > automatically into minibuffer command line. I think it makes
>> > us easier to use "grep-find" function.
>> There is a function `grep-default-command' in grep.el that does this.
>> I wonder why it's used in `grep', but not in `grep-find'. I think
>> we should do the same in `grep-find'.
> Yes, and as I've suggested before, if the region is active,
> then its contents, surrounded by "s, should be the default
> search string. Example code:
`grep-tag-default' already provides the active region. But it uses
`shell-quote-argument' instead of surrounding by quotes. I don't know
what is better, since it's harder to edit the command when
`shell-quote-argument' puts a backslash before every space
and some other characters.
Another drawback of `grep-tag-default' is that it provides only
one alternative. This is unlike `read-regexp' that proposes
a list of possible default values. So `grep-tag-default' could be
improved to do the same.