bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5056: marked as done (Minor fix for a defcustom in savehist mode (pa


From: Emacs bug Tracking System
Subject: bug#5056: marked as done (Minor fix for a defcustom in savehist mode (patch included))
Date: Mon, 30 Nov 2009 23:45:04 +0000

Your message dated Tue, 1 Dec 2009 00:39:47 +0100
with message-id <address@hidden>
and subject line Re: bug#5056: Minor fix for a defcustom in savehist mode 
(patch  included)
has caused the Emacs bug report #5056,
regarding Minor fix for a defcustom in savehist mode (patch included)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
5056: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5056
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Minor fix for a defcustom in savehist mode (patch included) Date: Thu, 26 Nov 2009 22:39:00 -0800 User-agent: Thunderbird 2.0.0.23 (X11/20090817)
While customizing savehist mode through the emacs Custom interface, I
discovered that I could not set `savehist-autosave-interval' to nil
because the custom buffer only had an integer entry field for that
variable, although the docstring said that nil was a valid value. So I
edited the custom definition to allow choosing either nil or an integer,
instead of just an integer. I also added labels to the two choices to
make things clearer for the user. Here is the one-line diff (assuming
that it doesn't get too badly mangled in transit):

BEGIN DIFF
*** old/savehist.el    2009-11-26 21:47:52.378311830 -0800
--- new/savehist.el    2009-11-26 21:19:12.118518476 -0800
***************
*** 120,126 ****
 (defcustom savehist-autosave-interval (* 5 60)
   "The interval between autosaves of minibuffer history.
 If set to nil, disables timer-based autosaving."
!   :type 'integer
   :group 'savehist)

 (defcustom savehist-mode-hook nil
--- 120,127 ----
 (defcustom savehist-autosave-interval (* 5 60)
   "The interval between autosaves of minibuffer history.
 If set to nil, disables timer-based autosaving."
!   :type '(choice (const :tag "Disabled" nil)
!                  (integer :tag "Seconds" 300))
   :group 'savehist)

 (defcustom savehist-mode-hook nil
END DIFF

Here is my attempt at manually writing a changelog entry:

BEGIN CHANGELOG
    2009-11-62  Ryan C. Thompson  <address@hidden>

            * savehist.el: Allow setting `savehist-autosave-interval'
              to nil in Custom.
END CHANGELOG

If it matters, you have my blessing to license this code however you please.

- Ryan Thompson
--- Begin Message --- Subject: Re: minor bugfix for savehist mode Date: Mon, 31 Aug 2009 13:37:23 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux)
"Ryan C. Thompson" <address@hidden> writes:

> I would like to submit a minor improvement for savehist mode. I
> noticed that the variable savehist-autosave-interval could be either
> an integer or nil, but its definition allowed it to be customized only
> as an integer. I changed the definition to allow it to also be set to
> nil in Custom.

Please post your bugfix to Emacs maintainers so it gets incorporated
into the next release.  I no longer actively maintain savehist-mode.

Thank you.

--- End Message ---

--- End Message ---
--- Begin Message --- Subject: Re: bug#5056: Minor fix for a defcustom in savehist mode (patch included) Date: Tue, 1 Dec 2009 00:39:47 +0100
On Fri, Nov 27, 2009 at 07:39, Ryan C. Thompson <address@hidden> wrote:

> make things clearer for the user. Here is the one-line diff (assuming
> that it doesn't get too badly mangled in transit):

Applied, thanks.

    Juanma

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]