bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4565: marked as done (23.1.50; [Patch] The doctor thinks that "famil


From: Emacs bug Tracking System
Subject: bug#4565: marked as done (23.1.50; [Patch] The doctor thinks that "family" is an adverb)
Date: Sat, 17 Oct 2009 03:20:05 +0000

Your message dated Fri, 16 Oct 2009 23:10:43 -0400
with message-id <address@hidden>
and subject line Re: Bug#4565; [Patch] The doctor thinks that "family" is an 
adverb
has caused the Emacs bug report #4565,
regarding 23.1.50; [Patch] The doctor thinks that "family" is an adverb
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
4565: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4565
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 23.1.50; [Patch] The doctor thinks that "family" is an adverb Date: Sun, 27 Sep 2009 16:57:56 +0200
When calling "psychoanalyze-pinhead" in Emacs from today's CVS trunk,
but with the yow.lines file restored from Emacs 21, it stops at a
phrase containing the word "family".

To reproduce:
   $ emacs -Q
   M-x doctor RET
   While I'm in LEVITTOWN I thought I'd like to see the NUCLEAR FAMILY!!
   RET RET

Actual behaviour:
   Minibuffer prompt "family what ?" appears.

Expected behaviour:
   Doctor printing an answer like "Tell me something about your family."

The problem is in function doctor-adverbp which recognises all words
ending with "ly" as adverbs. The patch included below fixes it for
some common words.

(Actually, there are many more non-adverbs ending with "ly". I've
limited it to words contained in the list of 850 words of Ogden's
Basic English, or in yow.lines.)

Ulrich


2009-09-27  Ulrich Mueller  <address@hidden>

        * play/doctor.el (doctor-adverbp): Exclude some common nouns.

--- emacs-orig/lisp/play/doctor.el
+++ emacs/lisp/play/doctor.el
@@ -1190,7 +1190,8 @@
 (defun doctor-adverbp (xx)
   (let ((xxstr (doctor-make-string xx)))
     (and (>= (length xxstr) 2)
-        (string-equal (substring (doctor-make-string xx) -2) "ly"))))
+        (string-equal (substring (doctor-make-string xx) -2) "ly")
+        (not (memq xx '(family fly jelly rally))))))
 
 (defun doctor-articlep (x)
   (memq x '(the a an)))


--- End Message ---
--- Begin Message --- Subject: Re: Bug#4565; [Patch] The doctor thinks that "family" is an adverb Date: Fri, 16 Oct 2009 23:10:43 -0400 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Thanks; applied.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]