bug#3677: 23.0.95; facemenu-read-color should not require match

[Jay Berkenbilt]

[I apologize if this is a duplicate.  M-x report-emacs-bug doesn't
appear to have called my sendmail-send-it function, so my original
report is likely to be rejected as spam from many recipients.]

  M-x set-cursor-color RET #9ef RET

  -> [no match]

The same thing happens with set-foreground-color and
set-background-color, all of which call facemenu-read-color, but not
with set-face-foreground and set-face-background, which do not.  All
above mentioned functions do completing reads on color names, which is
appropriate, but they should also accept #xxx, #xxxxxx, rgb:xx/xx/xx,
etc.  If you do M-: (set-cursor-color "#9ef"), it works, so this is
clearly a case of the wrong kind of completing read being done.

In facemenu-read-color, in the let statement, require-match is
initialized this way:

         (require-match (not (eq window-system 'ns)))

I believe it should always have the value nil so that people are free
to enter colors in alternative ways.


In GNU Emacs 23.0.95.1 (i686-pc-linux-gnu, GTK+ Version 2.10.4)
 of 2009-06-23 on motoko.argon.local
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  
'--prefix=/opt/tps/packages/linux.ix86.rhel5/emacs-23.0.95-1''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Conf[Xdefaults]

Minor modes in effect:
  diff-auto-refine-mode: t
  which-function-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-n C-n C-n C-n C-b C-d 9 C-d e C-x C-s C-p C-p C-p 
C-p C-b C-b C-d 8 d C-d C-x C-s C-d e C-x C-s C-x o 
C-v C-x C-x o C-x o C-b C-b C-b C-d d C-n C-n C-n C-n 
<backspace> e C-x C-s <C-backspace> <C-backspace> <C-backspace> 
<C-backspace> C-x C-s C-x 0 M-< C-v C-v C-v C-v C-v 
C-v C-v C-v C-v M-v M-v C-SPC C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-g M-v M-v M-v 
M-v M-v C-x b <return> C-f C-f C-b C-d b C-n C-n C-n 
C-n <backspace> c C-x C-s <C-backspace> <C-backspace> 
<C-backspace> <C-backspace> C-x C-s C-x b <return> 
C-s s k y C-x b <return> C-x v u y e s <return> C-n 
C-n C-n C-n C-k C-z C-o M-b 0 <backspace> 9 e f C-k 
C-p C-p C-p C-p <M-backspace> 8 d e C-x C-s <C-M-S-delete> 
C-n C-n C-n C-n C-n M-b C-k b l a c k C-x C-s <C-M-S-delete> 
M-x C-g C-x b C-g C-x C-f ~ / X r <tab> c o <tab> <return> 
C-s c u r s o r C-z C-o C-s C-s C-s C-e C-l M-b C-k 
9 e f C-x b <return> C-x b <return> C-x C-s C-x b <return> 
C-x b <return> M-x s e t SPC c u <tab> <return> # 9 
9 e e f f <return> <M-backspace> <backspace> M-p C-k 
' <backspace> # 9 e f <return> C-g M-: ( s e t - c 
u r s o r - c o l o r SPC " # d <backspace> 9 0 e f 
<backspace> <backspace> <backspace> e f " ) <return> 
C-a C-e M-x r e p o r t SPC b <backspace> e m SPC b 
SPC <return>

Recent messages:
Saving file /home/jberkenb/.local/share/themes/qtheme/openbox-3/themerc...
Wrote /home/jberkenb/.local/share/themes/qtheme/openbox-3/themerc
Quit [2 times]
Note: file is write protected
Mark saved where search started
Checking out /home/jberkenb/Xresources/color...done
Mark saved where search started
Saving file /home/jberkenb/Xresources/color...
Wrote /home/jberkenb/Xresources/color
Quit
nil