[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#3303: delete-frame raises old (invisible) frame
From: |
Stefan Monnier |
Subject: |
bug#3303: delete-frame raises old (invisible) frame |
Date: |
Sun, 17 May 2009 16:43:54 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) |
>> Still, the
>>
>> #ifdef NS_IMPL_COCOA
>> /* term gets no other notification of this */
>> if (for_deletion)
>> Fraise_frame(Qnil);
>> #endif
>>
>> in frame.c looks plain wrong and should probably just be deleted:
>> frame-selection is never intended to raise (or lower) any frame.
>> If this `raise' is really necessary, then it needs a much more extensive
>> comment justifying its presence.
>> Adrian, could you remove this code, or justify clearly why it's here?
> I think it is there because we need to raise another (visible) frame when
> a frame is deleted. This is standard behavior (and sensible).
This is a behavior which depends on the window-management policy, so
it's the responsibility of the window-manager (which may even decide
that the focus should return to some other application, which would make
a lot of sense if the frame was created via $EDITOR=emacsclient).
So, I'd still want to know what undesirable behavior would happen under
NS if we don't call Fraise_frame here (and also, why it needs to be
called here rather than elsewhere).
Stefan
- bug#3303: delete-frame raises old (invisible) frame, David Reitter, 2009/05/15
- bug#3303: delete-frame raises old (invisible) frame, Stefan Monnier, 2009/05/17
- bug#3303: delete-frame raises old (invisible) frame, David Reitter, 2009/05/17
- bug#3303: delete-frame raises old (invisible) frame, Adrian Robert, 2009/05/17
- bug#3303: delete-frame raises old (invisible) frame, Stefan Monnier, 2009/05/17
- bug#3303: delete-frame raises old (invisible) frame, YAMAMOTO Mitsuharu, 2009/05/18
- bug#3303: delete-frame raises old (invisible) frame, Adrian Robert, 2009/05/18
- bug#3303: delete-frame raises old (invisible) frame, David Reitter, 2009/05/18
- bug#3303: delete-frame raises old (invisible) frame, Stefan Monnier, 2009/05/18
- bug#3303: delete-frame raises old (invisible) frame, David Reitter, 2009/05/18
- bug#3303: delete-frame raises old (invisible) frame, Stefan Monnier, 2009/05/18