[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#3142: 23.0.92; split-window-prefered-function should be able to use
From: |
Stefan Monnier |
Subject: |
bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically |
Date: |
Thu, 30 Apr 2009 14:20:58 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) |
>> + (defcustom split-window-preferred-function 'split-selected-window
>> + "Function called by `display-buffer' to split a window.
>> + The window that shall be split is selected when this function is
>> + called. The function is supposed to either return the new window
>> + or nil if the window can (or shall) not be split."
>> + :type 'function
>> + :version "23.1"
>> + :group 'windows)
> If setting this option to `split-window-horizontally' and
> `split-window-vertically' is possible and it works correctly
> with these value, then I suggest adding them as constants,
> e.g. "Always split horizontally" and "Always split vertically".
Agreed (does :options work in such a case?).
> Also I suggest keeping the common function name prefix
> "split-window-",
Yes, please.
> i.e. instead of `split-selected-window' to name it something like
> "split-window-sensibly" or "split-window-with-thresholds".
Or split-window-dwim, split-window-somehow.
Stefan
PS: Other than that, the code looks fine.
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, (continued)
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, Juri Linkov, 2009/04/28
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, Stefan Monnier, 2009/04/28
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, martin rudalics, 2009/04/29
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, Juri Linkov, 2009/04/29
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, martin rudalics, 2009/04/29
- bug#3142: 23.0.92; split-window-prefered-function should be able to usesplit-window-horizontally/split-window-vertically, Drew Adams, 2009/04/29
- bug#3142: 23.0.92; split-window-prefered-function should be able to usesplit-window-horizontally/split-window-vertically, martin rudalics, 2009/04/30
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, Stefan Monnier, 2009/04/29
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, martin rudalics, 2009/04/30
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically, Juri Linkov, 2009/04/30
- bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically,
Stefan Monnier <=