bug#1191: How to contribute back changes for Emacs on Solaris

[Dan Nicolaescu]

Ali Bahrami <ali_gnu@emvision.com> writes:

  > Dan Nicolaescu wrote:
  > > Ali Bahrami <ali_gnu@emvision.com> writes:
  > >
  > >   > This message is a follow up to one I sent to emacs-devel
  > >   > last July:
  > >   >   >
  > > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html
  > >   >   > The question had to do with why emacs wasn't using dldump()
  > >   > to produce the dumped executable under Solaris. It had been using it
  > >   > up until 2002, at which point it was commented out, and it wasn't
  > >   > clear why. No one knew the reason, and the consensus was "try it and 
see".
  > >   >   > Since then, I've done some work to integrate emacs with
  > >   > OpenSolaris as a standard package. I turned on dldump(),
  > >   > and have been using the emacs binaries built with it daily
  > >   > since July without issue.
  > >   >   > So now, I have some things I'd like to send back up stream
  > >   > and get integrated into the emacs distribution:
  > >   >   >   - Man pages for things installed to /usr/bin that
  > > didn't
  > >   >         already have a manpage:
  > >   >               b2m.1
  > >   >               ebrowse.1
  > >   >               grep-changelog.1
  > >   >               rcs-checkin.1
  > >   >       - Small changes to config.guess and configure to properly
  > >   >         detect amd64 hardware running Solaris.
  > >   >       - Use dldump() instead of the generic ELF dump code
  > >   >         under Solaris.
  > >   >       - Use the system malloc under Solaris (at least with
  > >   >         amd64, emacs crashes without this).
  > >   >   > The manpages can be viewed at:
  > >   >   >
  > > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1
  > >   > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1
  > >   > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1
  > >   > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1
  > >   >   > and the patches at:
  > >   >   >
  > > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch
  > >   > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch
  > >   > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch
  > >   > 
http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch
  > >   >   > The patches are for emacs 22.1. I've examined 22.3, and the
  > >   > changes are applicable there as well. If 22.1 diffs are OK,
  > >   > that's easiest for me, but if not, then please let me know what
  > >   > I need to supply. These diffs are all very short, affecting a
  > >   > small number of lines in each file.
  > >   >   > So my questions: How can I go about submitting these
  > > changes?
  > >   > Is there someone who might work with me to get this done?
  > >   > What format would you need to get them in, and where can
  > >   > I send them?
  > >
  > > Your patches for the Solaris configuration are now in.
  > > config.guess has been updated from upstream with your changes.
  > > There's a man page for ebrowse now.
  > > Not sure what to do about the man pages for b2m, grep-changelog, and
  > > rcs-checkin.  You might want to open a separate bug for them.
  > >
  > > Thanks
  > >
  > >         --dan
  > 
  > 
  > I'm not sure what I'll do about the manpages, but I don't consider them 
part of
  > this bug anymore.
  > 
  > So, we appear to be done, except for the issue I flagged a couple
  > of days ago. Ben made a modification to my patch for config.guess
  > (dropping the use of a fully qualified path for 'echo') that causes
  > emacs to not build correctly for a Solaris user using the bash shell.
  > It does build successfully, but will always choose to build a 64-bit binary.
  > 
  > I sent mail to Ben about it, and we'll see what he says. However, you
  > should probably hold off on closing things out just yet.

Ben made the changes you requested:

commit 7086ee26381fdcc645d12c3177ee0be072dd82ef
Author: Ben Elliston <bje@gnu.org>
Date:   Thu Dec 11 15:31:45 2008 +1100

        * config.guess (i86pc:SunOS:5.*:*, i86xen:SunOS:5.*:*): The full
        path to /usr/bin/echo is necessary to work around the shell
        builtins for echo that do not handle newlines.  From Ali
        Bahrami.

and those are checked in the emacs CVS now.  Is that what you had in
mind?  If yes, please verify that things work for you now.

       --dan