bug#1186: 23.0.60; Abort trap when loading dbus in tty

[Michael Albinus]

Magnus Henoch <mange@freemail.hu> writes:

> With more debugging and less optimization I get:
>
> xd_read_message: Event received: DBUS_MESSAGE_TYPE_SIGNAL 2 
> org.freedesktop.DBus /org/freedesktop/DBus org.freedesktop.DBus NameAcquired 
> (:1.10)
> Breakpoint 1, abort () at /media/e/src/emacs/src/emacs.c:424              
> xd_retrieve_arg: s :1.10
> 424       kill (getpid (), SIGABRT);
> (gdb) bt full
> #0  abort () at /media/e/src/emacs/src/emacs.c:424
> No locals.
> #1  0x01a566cc in Fsignal (error_symbol=30504705, data=45395581) at 
> /media/e/src/emacs/src/eval.c:1651
>         allhandlers = (struct handler *) 0xffffc408
>         conditions = -277077180
>         string = -277132056
>         real_error_symbol = 190
>         bp = (struct backtrace *) 0x25d9273
> #2  0x01a56ab4 in xsignal (error_symbol=30504705, data=45395581) at 
> /media/e/src/emacs/src/eval.c:1750
> No locals.
> #3  0x01a56b18 in xsignal1 (error_symbol=30504705, arg=39686771) at 
> /media/e/src/emacs/src/eval.c:1767
> No locals.
> #4  0x01986158 in xd_initialize (bus=30504729) at 
> /media/e/src/emacs/src/dbusbind.c:688
>         s = "Did not receive a reply. Possible causes include: the remote 
> application did not send a reply, the message bus security policy blocked the 
> reply, the reply timeout expired, or the network connection w"...
>         connection = (DBusConnection *) 0x0
>         derror = {
>   name = 0x0, 
>   message = 0x0, 
>   dummy1 = 1, 
>   dummy2 = 0, 
>   dummy3 = 0, 
>   dummy4 = 0, 
>   dummy5 = 0, 
>   padding1 = 0xffffb850
> }

Thank you for the backtrace, it makes the picture clear. Fsignal must
not be called when reading events in the main loop. But xd_initialize does.

Could you, please, check the appended patch? It ought to prevent Fsignal
calls in this case.

> Magnus

Best regards, Michael.

txtYLl7k8N3wU.txt
Description: Text Data