Re: No Windows File Dialogue in Win98SE

[Jason Rumney]

Juergen Fenn wrote:
>   I tried to open a file in NTEmacs 22.1 on Windows 98 SE by selecting
>   File|Open File with the mouse. The dialogue did not appear.

Thanks, I think I have found the bug. If you can recompile Emacs (using
the mingw port of GCC, which is also free), then it would help us to
verify that this patch works before the next release.


*** w32fns.c    28 Mar 2007 23:13:00 +0100    1.288
--- w32fns.c    11 Jun 2007 00:24:10 +0100    
***************
*** 7902,7910 ****
      /* Apparently NT4 crashes if you give it an unexpected size.
         I'm not sure about Windows 9x, so play it safe.  */
      if (w32_major_version > 4 && w32_major_version < 95)
!       file_details->lStructSize = sizeof (new_file_details);
      else
!       file_details->lStructSize = sizeof (file_details);
 
      file_details->hwndOwner = FRAME_W32_WINDOW (f);
      /* Undocumented Bug in Common File Dialog:
--- 7910,7918 ----
      /* Apparently NT4 crashes if you give it an unexpected size.
         I'm not sure about Windows 9x, so play it safe.  */
      if (w32_major_version > 4 && w32_major_version < 95)
!       file_details->lStructSize = sizeof (NEWOPENFILENAME);
      else
!       file_details->lStructSize = sizeof (OPENFILENAME);
 
      file_details->hwndOwner = FRAME_W32_WINDOW (f);
      /* Undocumented Bug in Common File Dialog: