cvs-insert-strings fails if the first string is too wide

[Bob Rogers]

In GNU Emacs 21.3.1 (i586-suse-linux, X toolkit, Xaw3d scroll bars)
 of 2003-09-23 on Weber
configured using `configure '--with-gcc' '--with-pop' '--with-system-malloc' 
'--prefix=/usr' '--infodir=/usr/share/info' '--mandir=/usr/share/man' 
'--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--with-x' '--with-xpm' 
'--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--with-x-toolkit=lucid' 
'--x-includes=/usr/X11R6/include' '--x-libraries=/usr/X11R6/lib' 
'i586-suse-linux' 'CC=gcc' 'CFLAGS=-O2 -march=i586 -mcpu=i686 
-fmessage-length=0 -pipe    -DSYSTEM_PURESIZE_EXTRA=25000   
-DSITELOAD_PURESIZE_EXTRA=10000         -D_GNU_SOURCE ' 'LDFLAGS=-s' 
'build_alias=i586-suse-linux' 'host_alias=i586-suse-linux' 
'target_alias=i586-suse-linux''
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

   cvs-insert-strings fails with "Beginning of buffer" if the first
string is wider than the window width.  In this case, it is trying to
delete backwards before having inserted anything.

   To reproduce this:

   1.  Edit a version controlled file (preferably one with a long name),
and save it out.

   2.  "C-x v v"

   3.  Shrink the window with so that it is slightly smaller than the
file name.  In other words,

        (< (1- (window-width))
           (length (file-name-nondirectory buffer-file-name)))

should evaluate to t.

   4.  "C-c C-f" (log-edit-show-files).

Instead of seeing the file name listed in a new window, you will get a
"Beginning of buffer" message.

   The attached patch against CVS HEAD fixes the problem by avoiding
delete-char altogether.  It was developed using emacs 21.3, but the
cvs-insert-strings code in CVS is identical.

                                        -- Bob Rogers
                                           http://rgrjr.dyndns.org/


[ATTACHMENT /home/rogers/emacs/new-vc/cis-2.patch, text/plain]